Ethereal-dev: RE: [Ethereal-dev] Re: [Ethereal-cvs] rev 16040: /trunk/epan/:sigcomp_state_hdlr

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Anders Broman (AL/EAB)" <anders.broman@xxxxxxxxxxxx>
Date: Thu, 29 Sep 2005 09:39:12 +0200
Hi,
Well I suppose the whole check '&& n < UDVM_MEMORY_SIZE )' is redundant then.
Brg
Anders

-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx]On Behalf Of Guy Harris
Sent: den 29 september 2005 09:29
To: ethereal-dev@xxxxxxxxxxxx
Subject: [Ethereal-dev] Re: [Ethereal-cvs] rev 16040:
/trunk/epan/:sigcomp_state_hdlr.c


etxrab@xxxxxxxxxxxx wrote:

> Log:
>  It's the UDVM_MEMORY_SIZE that should be checked.

...but you have to check it against something wider than 16 bits:

	sigcomp_state_hdlr.c:549: warning: comparison is always true due to 
limited range of data type

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev