Wireshark · Ethereal-dev: SV: [Ethereal-dev] Should "dissect_tpkt_encap()" check only its "desegment" argument, rather than so

["Anders Broman" <a.broman@xxxxxxxxx>]

Hi,
That should probably make it easier to understand what needs to be done in
order to get the packets reassembled. 
But as this question has been asked a number of times perhaps the default
should be to do reassembly. Which has been discussed but I don't remember
the arguments for and against. 
Best regards
Anders

-----Ursprungligt meddelande-----
Från: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx] För Guy Harris
Skickat: den 23 september 2005 20:39
Till: Ethereal development
Ämne: [Ethereal-dev] Should "dissect_tpkt_encap()" check only its
"desegment" argument, rather than sometimes directly checking
tpkt_desegment?

Anders Broman (AL/EAB) wrote:

> Check your preferenc settings ( Edit->preferences->protocols ) fror
> TCP and TPKT and make sure that  reassembly is on.

Q.931 and TPKT both have "reassemble packets split across TCP segments" 
options.

"dissect_tpkt_encap()" is passed a "desegment" Boolean flag - Q.931 
passes it the Q.931 option in question - but sometimes it checks that 
argument and sometimes it directly checks "tpkt_desegment".  The TPKT 
dissector calls it, passing it "tpkt_desegment"; should it just check 
its "desegment" argument, so that the TPKT option isn't necessary for 
reassembling Q.931?

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev