Wireshark · Ethereal-dev: Re: [Ethereal-dev] Buildbot crash output

[Gerald Combs <gerald@xxxxxxxxxxxx>]

Guy Harris wrote:
> Gerald Combs wrote:
> 
>> How can we make sure that changes are properly tested _before_ they're
>> checked in?
> 
> 
> Should non-trivial changes to dissector behavior be checked into a
> branch, and could the buildbot (or a buildbot with some more hardware
> thrown at it - there's at least one developer I know of who could
> contribute to that) be usable as a "test this branch" machine, with a
> branch passing the test being propagated to the main branch?

This sounds do-able.  The final build step on the "test" builder could
copy the last revision from the "test" branch to the trunk.  We'd have
to keep the "test" branch and the trunk from getting too far out of sync
in order to minimize the risk of conflicts.

>>   The Buildbot environment MUST be able to test the code; i.e. captures
>>   that exercise the code should be added to the capture menagerie if
>>   they aren't already there.
> 
> 
> What if the change was done as a result of a private capture that can't
> be added to the menagerie?

A private Buildbot environment could be created for testing such
captures.  I'd be willing to sign NDAs for the captures if neccessary.