Ethereal-dev: [Ethereal-dev] Replace all appearances of g_assert in tvbuff.c with DISSECTOR_AS

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Sun, 18 Sep 2005 18:47:50 +0200
Hi List!
Just recognized, that the assert's in tvbuff are still using g_assert which will lead to a crash if a dissector is buggy in using tvb's.
I've noticed this while trying to reproduce bug #457 (where interestingly, instead of the reported dissector bug, I got a NULL pointer exception in tvbuff.c line 384).
Is there a reason to not use DISSECTOR_ASSERT's (and the ..._not_reached too) in tvbuff.c? 

Regards, ULFL