Ethereal-dev: [Ethereal-dev] Re: [Ethereal-cvs] rev 15791: /trunk/gtk/: expert_dlg.c
ulfl@xxxxxxxxxxxx wrote:
User: ulfl
Date: 2005/09/13 06:46 PM
Log:
Move "Expert Info" from "Statistics" to "Analyze" menu item.
*significantly* improve performance (100000 infos from ~5min to 25sec!)
Yup, g_list_append() works by starting at the beginning of the list and
scanning all the way to the end of the list. Welcome to the land of N^2....
The GTK+ 1.2[.x] documentation doesn't *explicitly* say you can append
to the last element of the list, rather than to the list as a whole;
that's what later versions of a GtkCList do (I forget whether they used
my patch for that or independently realized that setting up a long CList
works a *LOT* better if you do that), but if it's not explicitly stated
as working, there might be a risk that later implementations will break it.
If the items get put into a sorted list for display, though, prepending
is probably just as good.
