Ethereal-dev: Re: [Ethereal-dev] version numbers of xml and stats_tree?!? Is PACKAGE setting i

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: LEGO <luis.ontanon@xxxxxxxxx>
Date: Tue, 6 Sep 2005 14:11:45 +0200
Hi,

xml is about to go... It won't be a plugin anymore. I'm almost done
with the new one (that uses dtds to create the fields) and doesn't use
lex to parse the tvb but a tvb parser API I'll be checkin' in very
soon (this eve if I have time).  As for the negative version label I
agree, that was a bad idea.

The stats_tree plugin is an example of a plugin using the stats_tree
API, as the only useful pieces in there were moved to the relative
dissectors. I think it should it be in the source but it should not be
compiled.

As far as the version string of distributed plugins. I think that the
version should be that of the ethereal version they were build against
(i.e the  VERSION macro), and that ethereal should check it to be the
right one and refuse the plugin if it does not match ethereal's
version.

Luis

On 9/1/05, Ulf Lamping <ulf.lamping@xxxxxx> wrote:
> Hi!
> 
> Just noticed some interesting things regarding the plugins.
> 
> The xml dissector calls itself mate (in the PACKAGE setting), I've fixed
> this.
> 
> BTW: is the PACKAGE setting in all of the moduleinfo.h files needed at
> all, or should we completely remove it?
> 
> The xml dissector has version number 0.0.-1 ?!? I would think having a
> negative version number is a very bad idea...
> The stats_tree has version number 0.0
> 
> Both plugins were released with that version numbers in the 0.10.12
> release, which again IMHO isn't a good idea.
> 
> All other plugin versions starts with 0.0.1, which seems to make much
> more sense than the two above.
> 
> We might start with 0.0.0 for experimental plugins. However, if they are
> included in the Ethereal sources, they should be made stable as soon as
> possible ...
> 
> Regards, ULFL
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
> 


-- 
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan