Ethereal-dev: RE: [Ethereal-dev] value_string

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Anders Broman (AL/EAB)" <anders.broman@xxxxxxxxxxxx>
Date: Mon, 29 Aug 2005 09:28:22 +0200
Hi,
The value_string gsm_dtap_elem_string is not realy used as a value_string but rather as
an array where the string is fetched by a pointer.
    item =
	proto_tree_add_text(tree,
	    tvb, curr_offset, 5,
	    gsm_dtap_elem_strings[DE_LAI].strptr);

GSM_A will is not described by asn1, so the dissector will not be asn2eth:ified.

Brg
Anders

-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx]On Behalf Of ronnie sahlberg
Sent: den 28 augusti 2005 10:23
To: ethereal-dev@xxxxxxxxxxxx
Subject: [Ethereal-dev] value_string


I just finished going through and checking all value_strings in
dissectors and did find more than a handful ones that were not
properly terminated with a {0,NULL} entry.

These should all be fixed now.


In GMS-A   there was a very peculiar value_string : gsm_dtap_elem_string
that just looks very wrong.

Could one of the telco people have a look at that one    or should we
just wait until it is ASN2ETHified?

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev