Ethereal-dev: [Ethereal-dev] RFC: add more flags to the protocol tree for a start of an expert
Hi List!
First of all, I've changed the background color of the protocol items to
a very light gray. IMHO this makes it far better visible where the
protocol starts are and what the fields are.
As an attempt to bring some kind of expert mode into life, I've started
to add some more flags to the protocol items.
The protocol item in the protocol tree will have a gray background now,
which makes it much better visible.
Add some more optional flags to the protocol items, so more "special
cases" can be marked in the protocol tree. What came to my mind:
/** The protocol field has a bad checksum */
FI_CHECKSUM_ERROR
/** The protocol field has an unusual sequence (e.g. TCP window is zero) */
FI_SEQUENCE_WARNING
/** The protocol field has a bad sequence (e.g. TCP segment is lost) */
FI_SEQUENCE_ERROR
I've chosen this finer approach instead of only WARNING/ERROR, so we
could add some corresponding icons much later.
There might be others as well (e.g. FI_FRAGMENT_ERROR comes to my mind
right now).
I know this will start a controversial discussion, which is an error and
which should be noted at all, and which ...
Please note that this is not about finding causes of problems but "only"
a way to display it.
At several places we might need new preference settings, if this or that
condition should be marked as a error/warning/nothing. E.g. the TCP
checksum in some captures are completely broken, but won't indicate any
problem so Ethereal shouldn't warn about it.
Also the colors I've chosen are of course my personal preference, we
might need some preference settings for that too...
Comments / Ideas / Flame wars?
Regards, ULFL
