Ethereal-dev: Re: [Ethereal-dev] warnings in win32 build

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Fri, 5 Aug 2005 14:20:53 +0200
On Fri, Aug 05, 2005 at 10:55:02AM +0100, Graham Bloice wrote:
> The following warnings were seen in a win32 build from SVN 15221:
...

I'm currently in the process of fixing the trivial warnings of the type
you mention - with gcc 4 they look like this:
packet-wsp.c:3373: warning: assignment discards qualifiers from pointer target type
packet-wsp.c:3373: warning: assignment discards qualifiers from pointer target type
packet-wsp.c:3390: warning: assignment discards qualifiers from pointer target type
packet-wsp.c:3519: warning: assignment discards qualifiers from pointer target type
packet-wsp.c:3537: warning: assignment discards qualifiers from pointer target type
packet-wsp.c:3591: warning: assignment discards qualifiers from pointer target type
packet-wsp.c:3604: warning: assignment discards qualifiers from pointer target type
packet-wsp.c:3826: warning: assignment discards qualifiers from pointer target type
packet-wsp.c:4186: warning: assignment discards qualifiers from pointer target type
packet-wsp.c:4248: warning: assignment discards qualifiers from pointer target type
packet-wsp.c:4317: warning: assignment discards qualifiers from pointer target type

Trivial means: Just constify some string variables and return types.
Once I'm done with that I'll have a look at the remaining warnings and which of
them can be fixed in what ways (code rewrites, casts) and which can't.
I hope to finish the first (trivial) pass some time during the weekend.
You (and others) are very welcome to help with the second pass :-)

 ciao
      Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.