Add tvb_fake_unicode() to the list as well?
- Chris
-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx on behalf of LEGO
Sent: Sat 7/23/2005 8:27 PM
To: ronnie sahlberg; Ethereal development
Cc:
Subject: Re: [Ethereal-dev] EMEM tvb_get_xxx and further directions
If it goes to votes, I vote for it!
BTW: there's also tvb_memdup that should be handled the same way.
Luis
On 7/24/05, ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote:
> List
>
> There are only some 157 uses of tvb_get_string() and tvb_get_stringz()
> used by dissectors.
> They currently return g_malloced memory and a quick glance at their
> use is that most of them virtually immediately g_free() that same
> memory after doing a proto_tree_add_xxx or similar processing of them.
>
> I also saw some uses that obviously leak memory since g_free was never
> called, such as in packet-atalk.c .
>
>
> For this i think we should change the semantics for tvb_get_string[z]
> slightly and make it into
> tvb_get_string[z]_ep for allocations with packet lifetime and
> tvb_get_string[z]_ec for allocations with capture file lifetime.
>
>
> Opinions? maybe better names should be used?
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
--
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev
-----------------------------------------
This email may contain confidential and privileged material for the
sole use of the intended recipient(s). Any review, use, retention,
distribution or disclosure by others is strictly prohibited. If you are
not the intended recipient (or authorized to receive for the
recipient), please contact the sender by reply email and delete all
copies of this message. Also, email is susceptible to data corruption,
interception, tampering, unauthorized amendment and viruses. We only
send and receive emails on the basis that we are not liable for any
such corruption, interception, tampering, amendment or viruses or any
consequence thereof.
<<winmail.dat>>
