Hi,
I get the followibg warnings when compiling the patch:
register.c
packet-jxta.c
packet-jxta.c(424) : warning C4244: '+=' : conversion from 'unsigned __int64
' t
o 'unsigned int ', possible loss of data
packet-jxta.c(468) : warning C4244: '+=' : conversion from 'unsigned __int64
' t
o 'unsigned int ', possible loss of data
packet-jxta.c(630) : warning C4244: '+=' : conversion from 'unsigned __int64
' t
o 'int ', possible loss of data
packet-jxta.c(632) : warning C4244: '=' : conversion from 'unsigned __int64
' to
'int ', possible loss of data
Generating Code...
Best regards
Anders
-----Ursprungligt meddelande-----
Från: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx] För Mike Duigou
Skickat: den 14 juni 2005 19:22
Till: Ethereal development
Ämne: [Ethereal-dev] Updated Patch for JXTA
I've updated the JXTA related patch I submitted last week to the current
tree (including the g_assert fixes).
Please review for commit (now about 8 days since initial submission).
Mike
The original patch comment :
> jxta-14591.diffs : In order to get filtering of conversations and
> endpoints to work from the endpoints and conversations windows I found
> it necessary to add a new AT_URI address type and a SAT_JXTA. This also
> necessitated a change to to_str.c to avoid a buffer overflow problem.
> Please review these changes carefully.
>
> Also includes some changes to the jxta dissector to fix filtering on
> generated fields and some changes to the types used for ints/unsigned
ints.
>
> Fixes a bug with the processing of messages containing namespaces.
