Wireshark · Ethereal-dev: Re: [Ethereal-dev] Graph voip analysis regression for MGCP in 0.10.11 ?

[Ruud Linders <moztest@xxxxxxxxxxxxxxxxxxxx>]

Alejandro,

Yes, this patch fixes the problem for me applied on top of 0.10.11.

THanks.

Alejandro Vaquero wrote:
> Hi List,
>    find attached a patch to packet-mgcp to fix this (I think the code 
> was removed during the mgcp cleanup)
>
> Regards
> Alejandro
>
> Alejandro Vaquero wrote:
>
> > I'm traveling this week, but I'll take a look of this next week if 
> > nobody look into before. Could you please send the capture file?
> >
> > Thanks
> > Alejandro
> >
> > Ruud Linders wrote:
> >
> > > Voip graph analysis for MGCP seems to be missing several messages since
> > > ethereal 0.10.11. (I also tried yesterday's svn checkout, no difference)
> > > Now it starts with the CRCX (create connection), the NTFY 
> > > hookdetect/digitsmaps
> > > are missing.
> > >
> > > Attached the ascii output from ethereal 0.10.10 (+ Francisco Alcoba's 
> > > initial
> > > patch to save to an ascii file) and 0.10.11 showing the initial 6 
> > > messages
> > > missing.
> > >
> > > Regards,
> > >     Ruud Linders
> > >
> > >
> > >
> > >  
> > >
> > > ------------------------------------------------------------------------
> > >
> > > Conv.| Time     | 10.29.63.7        | 172.17.146.35     |
> > > 0    |0.000     |         NTFY ObsEvt:hd                |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2427)   -------------------> (2727)   |
> > > 0    |0.002     |         200 (NTFY)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2427)   <------------------  (2727)   |
> > > 0    |0.004     |         RQNT DigitMap SigReq          |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2427)   <------------------  (2727)   |
> > > 0    |0.080     |         200 (RQNT)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2427)   -------------------> (2727)   |
> > > 0    |6.588     |         NTFY ObsEvt:0,3,3,0,          |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2427)   -------------------> (2727)   |
> > > 0    |6.589     |         200 (NTFY)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2427)   <------------------  (2727)   |
> > > 0    |6.591     |         CRCX      |                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2427)   <------------------  (2727)   |
> > > 0    |6.639     |         200 (CRCX) SDP ( g71          |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2427)   -------------------> (2727)   |
> > > 0    |6.985     |         MDCX SDP ( g711A)             |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2427)   <------------------  (2727)   |
> > > 0    |7.020     |         100 (MDCX)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2427)   -------------------> (2727)   |
> > > 0    |7.030     |         200 (MDCX)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response Duplicate
> > >     |          |(2427)   -------------------> (2727)   |
> > > 0    |7.031     |         RQNTSigReq:rt                 |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2427)   <------------------  (2727)   |
> > > 0    |7.114     |         200 (RQNT)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2427)   -------------------> (2727)   |
> > > 0    |9.015     |         MDCX      |                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2427)   <------------------  (2727)   |
> > > 0    |9.065     |         100 (MDCX)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2427)   -------------------> (2727)   |
> > > 0    |9.077     |         200 (MDCX)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response Duplicate
> > >     |          |(2427)   -------------------> (2727)   |
> > > 0    |11.866    |         NTFY ObsEvt:hu                |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2427)   -------------------> (2727)   |
> > > 0    |11.867    |         200 (NTFY)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2427)   <------------------  (2727)   |
> > > 0    |11.868    |         DLCX      |                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2427)   <------------------  (2727)   |
> > > 0    |11.953    |         250 (DLCX)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2427)   -------------------> (2727)   |
> > >  
> > >
> > > ------------------------------------------------------------------------
> > >
> > > Conv.| Time     | 172.17.146.35     | 10.29.63.7        |
> > > 0    |6.591     |         CRCX      |                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2727)   -------------------> (2427)   |
> > > 0    |6.639     |         200 (CRCX) SDP ( g71          |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2727)   <------------------  (2427)   |
> > > 0    |6.985     |         MDCX SDP ( g711A)             |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2727)   -------------------> (2427)   |
> > > 0    |7.020     |         100 (MDCX)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2727)   <------------------  (2427)   |
> > > 0    |7.030     |         200 (MDCX)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2727)   <------------------  (2427)   |
> > > 0    |7.031     |         RQNT      |                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2727)   -------------------> (2427)   |
> > > 0    |7.114     |         200 (RQNT)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2727)   <------------------  (2427)   |
> > > 0    |9.015     |         MDCX      |                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2727)   -------------------> (2427)   |
> > > 0    |9.065     |         100 (MDCX)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2727)   <------------------  (2427)   |
> > > 0    |9.077     |         200 (MDCX)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2727)   <------------------  (2427)   |
> > > 0    |11.866    |         NTFY      |                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2727)   <------------------  (2427)   |
> > > 0    |11.867    |         200 (NTFY)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2727)   -------------------> (2427)   |
> > > 0    |11.868    |         DLCX      |                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Request
> > >     |          |(2727)   -------------------> (2427)   |
> > > 0    |11.953    |         250 (DLCX)|                   |MGCP 
> > > aaln/1@xxxxxxxxxxxxxxxxxxxxxxxxxxx Response
> > >     |          |(2727)   <------------------  (2427)   |
> > >  
> > >
> > > ------------------------------------------------------------------------
> > >
> > > _______________________________________________
> > > Ethereal-dev mailing list
> > > Ethereal-dev@xxxxxxxxxxxx
> > > http://www.ethereal.com/mailman/listinfo/ethereal-dev
> > >  
> >
> > _______________________________________________
> > Ethereal-dev mailing list
> > Ethereal-dev@xxxxxxxxxxxx
> > http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
> ------------------------------------------------------------------------
>
> Index: packet-mgcp.c
> ===================================================================
> --- packet-mgcp.c	(revision 14467)
> +++ packet-mgcp.c	(working copy)
> @@ -1067,8 +1067,11 @@
>  {
>  	gint returnvalue = -1, tvb_current_offset,counter;
>  	guint8 tempchar, plus_minus;
> +	gchar **buf;
> +
>  	tvb_current_offset = offset;
>  	*hf = NULL;
> +	buf = NULL;
>  
>  	if (len > 0)
>  	{
> @@ -1184,6 +1187,7 @@
>  				break;
>  			case 'S':
>  				*hf = &hf_mgcp_param_signalreq;
> +				buf = &(mi->signalReq);
>  				break;
>  			case 'D':
>  				*hf = &hf_mgcp_param_digitmap;
> @@ -1191,6 +1195,7 @@
>  				break;
>  			case 'O':
>  				*hf = &hf_mgcp_param_observedevent;
> +				buf = &(mi->observedEvents);
>  				break;
>  			case 'P':
>  				tvb_current_offset++;
> @@ -1262,6 +1267,11 @@
>  			tvb_current_offset++;
>  			tvb_current_offset = tvb_skip_wsp(tvb,tvb_current_offset, (len - tvb_current_offset + offset));
>  			returnvalue = tvb_current_offset;
> +
> +			/* set the observedEvents or signalReq used in Voip Calls analysis */
> +			if (buf != NULL) {
> +				*buf = tvb_get_string(tvb, tvb_current_offset, (len - tvb_current_offset + offset));
> +			}
>  		}
>  	}
>  	else
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev