Ethereal-dev: Re: [Ethereal-dev] Two Win32 problems with 0.10.11 - building & packaging
Ulf Lamping wrote:
> Jaap Keuter wrote:
>
>
>>On Thu, 5 May 2005, Maynard, Chris wrote:
>>
>>
>>
>>
>>>I ran into 2 problems with 0.10.11:
>>>
>>>1) Building: It seems that the xml plugin file,
>>>plugins\xml\xml_lexer.c unconditionally includes <unistd.h>,
>>>which caused my Win32 build to fail.
>>>
>>>To get past this, I wrapped it with the following:
>>>#ifdef HAVE_UNISTD_H
>>>#include <unistd.h>
>>>#endif
>>>
>>>
>>>2) Packaging: The packaging\nsis\ethereal.nsi file
>>>contains the following line:
>>>!include "GetWindowsVersion.nsh"
>>>
>>>However, this file (attached) is not part of
>>>the distribution, so packaging fails without it.
>>>
>>>
>>
>>This seems very similar to the trouble I had with 0.10.10.
>>The first problem was in another file, but still...
>>Is there a pattern here?
>>
>>
>
> Yes, there is a pattern: We are all humans and make mistakes!
>
> Let's have a look:
>
> 1.) The file xml_lexer.c isn't included in the subversion repository.
> It's build from xml_lexer.l and might be build while generating the
> tarball or was build on your system. I currently only have a slow
> Internet link so I don't want to check the tarball myself if this file
> is included. BTW: possibly calling cleanbld.bat might already help.
>
> 2.) I've added the file GetWindowsVersion.nsh and just forgot to add it
> to the Makefile.am to get it into the tarball. I've fixed that minutes
> ago. I would have guessed that this problem should be detected by the
> distcheck run, but unfortunately it wasn't.
>
> Gerald might have a look if there's a way to automatically prevent such
> problems in the future, but he might be busy elsewhere ...
We could take the tarballs built by the Solaris build slave, copy them
to the Windows build slave, and try to compile them there. I'll add it
to the to-do list.
