Ethereal-dev: [Ethereal-dev] Re: BACnet Updates to APDU Part

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Tue, 26 Apr 2005 03:53:55 -0400
I very rarely compile for windows,
I see you add a new library  ICONV.LIB to the makefile   and i assume
to the dependencies.

Is this a library available on all windows boxens ?
I notice there is a libiconv package required for windows,   is this
this library referenced from the Makefile.nmake?

I dont really like that this dissector tries to implement its own
handwritten BER unmarshalling. There is already a too many of these
reimplementations of BER decoding helper functions in ethereal and we
should not add more. The ones we do have in packet-ber.c are the only
ones which are reasonably well tested, works reasonably well   and are
used by teh automatic asn.1 to ethereal compiler.



It seems bacapp is really just a protocol described by asn.1 and using
BER for encoding.
Instead of adding to this one   what really should be done is to
reimplement BACapp from scratch as a dissector generated automatically
from the ASN.1 definitions and using ASN2ETH.


Is the BACAPP ASN.1 protocol specification publicly available?




On 4/25/05, Herbert Lischka <herbert@xxxxxxxxxxxxxxxxx> wrote:
> Hi list
> 
> Sorry I forgot to add [PATCH] to the subject last time.
> 
> Here are some BACnet dissector improvements:
> 
> enhanced decoding of the APDU
> 
> please check in
> 
> Best Regards
> Herbert
> 
> 
>