Ethereal-dev: Re: [Ethereal-dev] Bug 72 (huge fragmentation offset)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Peter Johansson <Peter.Johansson@xxxxxxxxxxxx>
Date: Tue, 19 Apr 2005 23:04:33 +0200
Gerald Combs wrote:


Peter Johansson wrote:


Please consider my already applied patch for reassemble.c which can be
seen in http://www.ethereal.com/lists/ethereal-dev/200504/msg00300.html
This fixes a segv problem and informs the user of the incorrectly
decoded frame number.


Checked in.  It doesn't fix the capture that triggered bug 72 (on my
system, at least).  Gdb says:
It seems that I am unable to reproduce the crash at all, on Windows XP at least. I detected no problems whatsoever and have tried using versions 14136 (most recent) and 14096 of reassemble.c. I never reach any of the two lines (730 and 1184) in reassemble.c where memcpy(...) is called since in every call to fragment_add_common(...), when the call is made due to packet-fc's call to fragment_add(...), check_already_added is true which makes fragment_add_common(...) return on lines 802 or 804. 

/ Peter