A lot of the lists for strings in this dissector use locally defined structs
such as static struct type2str_t v2_idtypestr[] = {
and locally defined macros to search them.
It would be much better if these lists of strings were changed into a
struct value_string since htere are standard methods (val_to_str) in ethereal
to parse this kind of very common datastructure.
Using a value_string will also allow you to specify
VALS(value_string_name) in the
hf declarations which will make the GUI filter builder much prettier
for those that use that
one.
Note that a value_string must be terminated by a {0, NULL } entry.
can you consider refactoring all the lists of strings into being value_string ?
On Thu, 03 Mar 2005 01:26:05 +0900, Shoichi Sakane <sakane@xxxxxxxx> wrote:
> Hi, I posted the diff to support parsing IKEv2 packets a week ago.
> But it seems that no one probably care it. Are there something wrong
> in my patch ?
>
> > Hi, I improved packet-isakmp.c to support parsing the IKEv2 packets.
> > I made a diff from ethereal-0.10.9-SVN-13409. I have checked it with
> > our IKEv2 implementation, and it looks working fine. So could you
> > merge it to the main tree if you allow it ? or could you give me
> > comments or advise if you can not ? I attached the diff to this mail.
> >
> > Best regards,
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
