Ethereal-dev: Re: [Ethereal-dev] [patch] Search harder for krb5-config

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 23 Feb 2005 14:15:41 +0100
On Wed, Feb 23, 2005 at 10:24:58PM +1100, Brad Hards wrote:
> --- clean/ethereal-0.10.9-SVN-13436/acinclude.m4        2005-02-20 
> 15:25:24.000000000 +1100
> +++ ethereal-0.10.9-SVN-13436/acinclude.m4      2005-02-23 21:55:17.000000000 
> +1100
> @@ -986,7 +986,7 @@
>           AC_DEFINE(HAVE_MIT_KERBEROS, 1, [Define to use MIT kerberos])
>           fi
>         else
> -         AC_PATH_PROG(KRB5_CONFIG, krb5-config)
> +         AC_PATH_PROG(KRB5_CONFIG, krb5-config,, [$PATH:/usr/kerberos/bin])
>           if test -x "$KRB5_CONFIG"
>           then
>             KRB5_FLAGS=`"$KRB5_CONFIG" --cflags`
> 
> If that is OK, can it please be committed?

I don't like this. Please fix your PATH before calling krb5-config.
Either you want to use kerberos, then it should be added to your path, or
you don't, then it's irrelevant whether it is in the path or not.

 ciao
       Joerg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.