Wireshark · Ethereal-dev: Re: [Ethereal-dev] Crashes on Win98 and WinME fixed

[Guy Harris <gharris@xxxxxxxxx>]

Lars Roland wrote:
> Guy Harris schrieb:
> > Is WINDIR set on 95/98/Me?  
>
> It is set on 98 and ME, I don't know, if it is set on Win95.
> BTW, ADNS does *not* support Win95. Thus Ethereal doesn't support Win95 
> if built with ADNS, right?

Presumably - and I think the Windows version from the installer is built 
with ADNS, which would mean we don't support W95.

What happens if you try to use ADNS on W95?  Crash?  Addresses don't get 
resolved?

> > If so, should it be checking there?  
>
> Yes, I think it is better to use WINDIR than fixed entries with fixed 
> drive letters.

OK, I've checked in a change to use WINDIR, and to try first the NT (NT 
4.0/2K/XP/Server2K3) location for the hosts file and, if it doesn't find 
it there, try the OT (95/98/Me) location.  If WINDIR isn't set, it 
doesn't bother trying at all, rather than trying paths with fixed drive 
letters.

> > If so, should it use WINDIR rather than SYSTEMROOT?  
>
> I don't see any difference between them.

...other than SYSTEMROOT being set only on NT.

> I would use WINDIR instead of SYSTEMROOT.

That's what it's doing now.

> > In either case, should it try both %WINDIR%\hosts and 
> > %WINDIR%\system32\drivers\etc\hosts, to handle both 95/98/Me and 
> > NT4/2K/XP/Server2K3, or should it base that on whether it's Windows OT 
> > (95/98/Me) or NT (NT4/2K/XP/Server2K3)?
>
> I guess it is better to try both on any Windows.

That's what it's doing now - what's the advantage to that over calling 
GetVersionEx() and basing it on the dwPlatformId value?

> > Should we just punt, rather than trying well-known paths, if 
> > {WINDIR,SYSTEMROOT} isn't set?
>
> I would skip fixed paths with fixed drive letters.

That's what it's doing now.