Ethereal-dev: Re: [Ethereal-dev] Ethereal patch for TLS Hello Extensions (RFC 3546)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 26 Dec 2004 14:53:27 -0800
Jouni Malinen wrote:


Oops.. I did some more testing and it became clear that using
tvb_length_remaining() was not exactly the best thing to do here. This
worked fine for frames that ending in the TLS extensions, but it seemed
to confuse parsing of things following ClientHello/ServerHello. The
attached patch changes this to use the length of the Client/ServerHello
explicitly to limit the area for TLS extensions parsing. Is this the
correct way of handling this in Ethereal


Yes.  I've checked that in.
"tvb_length_remaining()" should rarely be used - for one thing, it represents the amount of *captured* data remaining, not the amount of data remaining in the packet as received.