ronnie sahlberg <ronniesahlberg@xxxxxxxxx>, Ethereal development <ethereal-dev@xxxxxxxxxxxx> schrieb am 07.12.04 19:08:15:
>
> > packet-dcom.c (generic dcom helper stuff)
> Why do you need this file?
> In particular, what helpers do you envision being in this file that
> should not be in the dcerpc helper file?
>
You mean packet-dcerpc.c/.h I would guess.
The main thing in that new file packet-dcom.c (after some cleanup I have to do in that file) will be the dissection of the ORPCTHIS and ORPCTHAT headers, which starts almost every "custom" DCOM call.
After looking deeper into it, it might be a good idea to put all the generic DCOM parts into packet-dcom.c (and don't create packet-dcom-types.c I've mention before).
This file will include the dissection of general DCOM data (ORPCTHIS, ORPCTHAT, VARIANT, HRESULT, COMVERSION, SAFEARRAY, BSTR, LPWSTR, ...) which is used in several different places of my own "currently unreleased" dissectors. These are also used in other DCOM interfaces, like the oxid resolver.
I would think, that all of these datatypes are DCOM specific, so these shouldn't be put into some general dcerpc file.
But before going deeper into the details, what about the filenames in general?
Regards, ULFL
__________________________________________________________
Mit WEB.DE FreePhone mit hoechster Qualitaet ab 0 Ct./Min.
weltweit telefonieren! http://freephone.web.de/?mc=021201
