Ethereal-dev: Re: [Ethereal-dev] Re: [Ethereal-cvs] Rev 12522: /trunk/epan/dissectors/: packet

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Mon, 22 Nov 2004 19:37:38 +1100
On Sun, 14 Nov 2004 13:11:06 -0800, Guy Harris wrote:
> ronnie sahlberg wrote:
> 
> > it would be nice if there was a makefile in asn1 which would loop over
> > all subdirectories where asn1 based dissectors are held (asn1/)
> > and then from inside each directory run a new makefile to
> > run the commandline to compile the thing into packet-protocol.[ch] and
> > automatically copy them across to epan/dissector.
> 
> Or if we just put the packet-XXX-template.[ch] files, *.asn files, and
> *.cnf files into the epan/dissector directory, and put in dependencies
> and rules to specify what files and commands are used to generate
> packet-XXX.c, so that a regular make could rebuild them.
> 

Thinking things over, I am not sure that is a good approach.
It would make it difficult to get an overview which files belong to
which dissector.
For most stuff down in epan/dissectors this is easy :
to find all files related to IP we just look at packet-ip.c and packet-ip.h

These autogenerated files will consist of at least 4 and possibly 5
different files :
PROTOCOL_DEFINITION.asn
packet-PROTOCOL-template.[ch]
protocol.cnf
protocol-exp.cnf

I think it would be cleaner to keep them in their own directory 
protocol by protocol.
(though if that is opposed i am willing to move them to
epan/dissectors one by one)
Since there are so many of them now it is starting to become painful
to manually rebuild all of them everytime a change in asn2eth needs
them all to be regenerated.