Ethereal-dev: Re: [Ethereal-dev] new ICE dissector (second try)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Wed, 06 Oct 2004 02:09:59 -0700
francesco fondelli wrote:


Anyway I'm using it and it works fine for me. I hope it could be useful
for someone else.
I checked it in, with some cleanups (such as getting rid of GCCisms such as declarations in the middle of a block).
TCP reassembly shouldn't be hard to add, if you use "tcp_dissect_pdus()"; the "fixed_len" argument should be ICEP_HEADER_SIZE (as the last field in the header is the message length), the "get_pdu_len()" routine should just return "tvb_get_letohl(tvb, 10)" (as the message length includes the header), and the ICE dissector should do heuristic checks and then call "tcp_dissect_pdus()" to dissect the packets.
It would probably be sufficient for the heuristic check to check only for the magic number at the beginning of the packet.