Wireshark · Ethereal-dev: Re: [Ethereal-dev] RTP Graph analysis

[Guy Harris <gharris@xxxxxxxxx>]

Alejandro Vaquero wrote:

> 	Both gcc warnings fixed.

I checked in the fix to the "unused parameter" warning - as you sent it 
as a patch to the code that didn't have your changes, I had to do that 
by checking out the version before I checked in your changes, and 
applying the patch to that, which was a bit of extra work.

I fixed the old warning differently - instead of having an end-of-list 
entry, I just had it compute the number of elements in the array with 
the standard "sizeof array / sizeof array[0]" C trick, and had the loop 
iterate over the elements from 0 to "# of elements - 1".

That raises the question of what the RTP analysis code should do if the 
sampling rate for the payload type isn't known - should 
"rtp_packet_analyse()" just ignore the packet in that case?