Ethereal-dev: Re: [Ethereal-dev] packet-x509if.c small visual correction

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Tomas Kukosa <tomas.kukosa@xxxxxxxxxxx>
Date: Wed, 22 Sep 2004 09:31:54 +0200
It is output of the ASN2ETH compiler.
It is intended for the new PER/BER API but I have forgotten to suppress it for the original API. 
I will fix it.

  Tom

Yaniv Kaul wrote:


 From packet-x509if.c:

{ &hf_x509if_RDNSequence_item,
 { "Item[##]", "x509if.RDNSequence_item",
   FT_UINT32, BASE_DEC, NULL, 0,
   "RDNSequence/_item", HFILL }},
{ &hf_x509if_RelativeDistinguishedName_item,
 { "Item(##)", "x509if.RelativeDistinguishedName_item",
Do we really need the [##] and (##) ? Do they have any special meaning? A new notation for /*FIXME*/ perhaps? ;-) 

It seems that there are more places we can/should 'rename':

$ grep "\[##]" *.c
packet-cms.c:      { "Item[##]", "cms.RecipientEncryptedKeys_item",
packet-pkinit.c:      { "Item[##]", "pkinit.trustedCertifiers_item",
packet-pkix1implicit.c: { "Item[##]", "pkix1implicit.noticeNumbers_item", 
packet-x509af.c:      { "Item[##]", "x509af.Extensions_item",
packet-x509af.c:      { "Item[##]", "x509af.ForwardCertificationPath_item",
packet-x509af.c:      { "Item[##]", "x509af.theCACertificates_item",
packet-x509af.c:      { "Item[##]", "x509af.revokedCertificates_item",
packet-x509af.c:      { "Item[##]", "x509af.acPath_item",
packet-x509af.c:      { "Item[##]", "x509af.attributes_item",
packet-x509ce.c:      { "Item[##]", "x509ce.KeyPurposeIDs_item",
packet-x509ce.c: { "Item[##]", "x509ce.CertificatePoliciesSyntax_item", 
packet-x509ce.c:      { "Item[##]", "x509ce.policyQualifiers_item",
packet-x509ce.c:      { "Item[##]", "x509ce.PolicyMappingsSyntax_item",
packet-x509ce.c:      { "Item[##]", "x509ce.GeneralNames_item",
packet-x509ce.c:      { "Item[##]", "x509ce.AttributesSyntax_item",
packet-x509ce.c:      { "Item[##]", "x509ce.GeneralSubtrees_item",
packet-x509ce.c:      { "Item[##]", "x509ce.CRLScopeSyntax_item",
packet-x509ce.c:      { "Item[##]", "x509ce.StatusReferrals_item",
packet-x509ce.c:      { "Item[##]", "x509ce.CRLDistPointsSyntax_item",
packet-x509if.c:      { "Item[##]", "x509if.RDNSequence_item",

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev