Ethereal-dev: Re: [Ethereal-dev] MSVC build broken(Print.c changes) Patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Lars Roland <lars.roland@xxxxxxx>
Date: Tue, 27 Jul 2004 11:27:56 +0200
Guy Harris wrote:


So why is "print.c" part of libethereal?  Dissectors don't use it.

(If the answer is "because libethereal isn't just stuff that dissectors
would use, it's all stuff used both by Tethereal and Ethereal", should
there be a single library of stuff shared by Tethereal and Ethereal, or
should there be a library for dissection, which could be used by
applications using the dissectors but that don't, for whatever reason,
want to use the rest of the code that's currently in libethereal, and
another library for stuff that's not dissector-related but that's shared
by Ethereal and Tethereal?)
I added print.c to the files linked into libethereal as print.c includes some variables from packet-data.c and from packet-frame.c. We can try to add those variables to libethereal.def instead. But I am not sure, if libethereal.dll is still self-contained without print.c. I would have to to test it.
I don't like the idea of splitting libethereal.dll into more libraries. It is probably very difficult to create a self-contained library with just a subset of what is currently in libethereal. At least this is what I experienced when I tried to create a libethereal.dll for a first time. 

Best Regards,
Lars