Ethereal-dev: RE: [Ethereal-dev] Patch to allow "copy to clipboard as CSV" for the contents of
> Well, some comments on your patches:
>
> -please send in unified patches (including 3 lines before and
> after the
> actual changed part)
> -tell diff to ignore whitespace is also a good idea, as there
> are some
> whitespace changes in your patch (especially in the .h files)
> -please try to keep your ethereal source tree up to date
>
Will do in the future.
> Now about your changes:
>
> 1 There are some changes only done in hostlist_table.c but not in
> endpoint_talkers_table.c, please try to keep these two files
> as much the
> same as possible.
>
> 2 Why is: return strcmp (text1, text2); removed?
This corrects a bug IMHO. This eliminates a text sort on a numeric column.
>
> 3 Please note, you've only changed the seperate page
> dialog(s), but not
> the combined dialog (I've added that).
>
> I have updated an approach to the hostlist table (endpoints), but I'm
> still unsure if the button handling is a good idea, or if
> this should be
> triggered by the context menu.
I don't disagree. I'm a newbie to GTK, so it'll take some research to do it within the context menu.
>
>
> Thomas: Could you update your patch for the now called
> conversation tables?
It's attached.
Thanks for your comments and thanks for addiding my patch to great product.
tjp
>
> Regards, ULFL
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
Attachment:
conversations_table.c.diff
Description: conversations_table.c.diff
Attachment:
conversations_table.h.diff
Description: conversations_table.h.diff
