make packet-h235.c failed with a python syntax error. :-(
I will try later to upgrade python to a newer version.
What was the error?
I use Python 2.2.3 (ActivePython 2.2.3 Build 225).
I would propose ( but feel free to add your opinions, due to the large
number of coming asn dissectors we had better get it right now )
asn2eth.py lex.py yaxx.py should all go to /tools/
H235...asn h235.cnf and the two templates should all go in to /asn/h235/
packet-h235.c and packet-h235.h are both generated manually and installed as
normal dissectors in the makefiles,
It is a good idea.
To start with we do not add any definitions to any makefiles to generate
them using the python scripts automatically
but regenerate the files manually. Later when we have all the scripts
there in the distribution and we have got enough people using
a sufficiantly large number of different platforms and versions of python to
successfully regenerate the dissectors manually we add
makefiles to /asn/ and each individual /asn/ subdirectory?
People, What do you say?
Once we agree on where to put stuff I can checkin the python scripts and the
h235 source files to where we decide to place them
and start working on getting the build to work on all platforms, then we add
the autogeneration of the dissectors to the build chain?
Should we start by checking in the python scripts into /tools/ and the
h235 sources to the new directory /asn/h235 as a starting point?
I agree.
----- Original Message -----
From: "Tomas Kukosa"
Sent: Thursday, May 20, 2004 9:45 PM
Subject: Re: [Ethereal-dev] H.235 dissector
Hi,
the "single file output" is implemented.
The attached patch (against 0.10.4) contains all H.235 changes.
There are following new files (locations can be changed):
ASN2ETH compiler
tools/asn2eth.py
tools/lex.py
tools/yacc.py
H.235 sources for ASN2ETH compiler
H235-SECURITY-MESSAGES.asn
h235.cnf
Templates for packet-h235.c/.h files
(if anybode has better idea concerning names, feel free to change it)
packet-h235-tpl.h
packet-h235-tpl.c
Regards,
Tomas
Ronnie Sahlberg wrote:
Hi,
Can you change the script slightly so that it outputs only two files for
ethereal:
packet-xxx.c and packet-xxx.h
Just change the script to store the hf things in temporary fiels then
just
some
sed magic to glue them together into one .c file and one .h file.
This also removes those extra dependensies from the makefile.
The #include "packet-... .c" directives make the code confusing to read.
the asn file attached does not contain a copyright, a licence or any
history
where it came from.
