I would prefer packet-h235-template.[ch] to have it close to packet-h235.[ch] in
alphabetic order.
I hope it can be renamed before adding into CVS and I do not have to make a new patch.
Tomas
Olivier Biot wrote:
Hi Tomas,
As we have no real limitation on filename sizes, I'd suggest you use
'template' instead of 'tpl'. Maybe you want to write
template-h235.[ch] instead of packet-h235-template.[ch] to distinguish
between template files and actual dissector code?
Best regards,
Olivier
----- Original Message -----
From: "Tomas Kukosa" <tomas.kukosa@xxxxxxxxxxx>
To: "Ethereal development" <ethereal-dev@xxxxxxxxxxxx>
Sent: Thursday, May 20, 2004 1:45 PM
Subject: Re: [Ethereal-dev] H.235 dissector
| Hi,
| the "single file output" is implemented.
| The attached patch (against 0.10.4) contains all H.235 changes.
|
| There are following new files (locations can be changed):
| ASN2ETH compiler
| tools/asn2eth.py
| tools/lex.py
| tools/yacc.py
| H.235 sources for ASN2ETH compiler
| H235-SECURITY-MESSAGES.asn
| h235.cnf
| Templates for packet-h235.c/.h files
| (if anybode has better idea concerning names, feel free to
change it)
| packet-h235-tpl.h
| packet-h235-tpl.c
|
| Regards,
| Tomas
|
| Ronnie Sahlberg wrote:
|
| > Hi,
| >
| > Can you change the script slightly so that it outputs only two
files for
| > ethereal:
| > packet-xxx.c and packet-xxx.h
| > Just change the script to store the hf things in temporary fiels
then just
| > some
| > sed magic to glue them together into one .c file and one .h file.
| >
| > This also removes those extra dependensies from the makefile.
| >
| > The #include "packet-... .c" directives make the code confusing to
read.
| >
| > the asn file attached does not contain a copyright, a licence or
any history
| > where it came from.
| >
| >
| > ----- Original Message -----
| > From: "Tomas Kukosa"
| > Sent: Monday, May 03, 2004 11:04 PM
| > Subject: [Ethereal-dev] H.235 dissector
| >
| >
| >
| >>Hi,
| >> patch with the H.235 dissector is attached.
| >>Makefile is changed only for MSVC as I do not have Linux
environment.
| >>
| >>There are following new files (locations can be changed):
| >> ASN2ETH compiler
| >> tools/asn2eth.py
| >> tools/lex.py
| >> tools/yacc.py
| >> H.235 sources for ASN2ETH compiler
| >> H235-SECURITY-MESSAGESx.asn
| >> h235.cnf
| >> H.235 dissector (includes output of compiler)
| >> packet-h235.h
| >> packet-h235.c
| >>
| >>There is not README.asn2eth and the ASN2ETH compiler is far from
release
| >
| > version,
| >
| >>but I still work on it.
| >>
| >> Regards,
| >> Tom
