Ethereal-dev: Re: [Ethereal-dev] new field info flag FI_LINK, the field will act as a link to

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Sat, 15 May 2004 02:06:27 +0200
Guy Harris wrote:


On Fri, May 14, 2004 at 07:23:09PM +0200, Ulf Lamping wrote:

I've added FI_LINK to the possible flags in field_info.
This flag should be set, if a field references another packet (and using FT_FRAMENUM), like the fields: "response to this is in packet: 23" 

*All* FT_FRAMENUM fields refer to another packet - that's the whole
purpose of FT_FRAMENUM fields.  Are there any cases where an FT_FRAMENUM
field should *not* have that flag set?

Furthermore, the code currently requires that a field with FI_LINK set
be an FT_FRAMENUM field; is there any reason not to get rid of FI_LINK
and have *all* FT_FRAMENUM fields (and no other fields) be marked as
links?
The only reason not to do so: I wasn't sure if that's what you describe is really true.
As I think you're 100% correct with what you say, it will be better to remove the FI_LINK flag again and detect wether a link is present or not by the presence or absense of the FT_FRAMENUM type.
However, the main work was to implement the link mechanism and even more the formatting of the tree renderer and this will stay almost unchanged now :-) 

I will check-in the required changes soon.

Regards, ULFL