Ethereal-dev: Re: [Ethereal-dev] Re: [Ethereal-cvs] cvs commit: etherealREADME.win32
From: Ulf Lamping
| Guy Harris wrote:
|
| >On Sun, Feb 22, 2004 at 10:28:47AM -0600, Ulf Lamping wrote:
| >
| >
| >>ulfl 2004/02/22 10:28:47 CST
| >>
| >> Modified files:
| >> . README.win32
| >> Log:
| >> gtkclist.c is called ethclist.c now
| >>
| >>
| >
| >...and all the functions in it are called "eth_clist_..." now,
which
| >means that it no longer substitutes for GtkClist, it's our own
widget
| >for displaying packet lists, which is *currently* the same as the
GTK+
| >1.2[.x] GtkClist but will probably eventually no longer be (once
it's
| >made to work with GTK+ 2.x as well), e.g. I want to make it a
"virtual
| >clist" that calls back to a routine to get column text.
| >
| >As such, that step in README.win32 might no longer be necessary -
in
| >fact, if you're building with GTK+ 1.2[.x], I think it's necessary
to
| >*not* do it, as, when building with GTK+ 1.2[.x],
"gtk/packet_list.c"
| >uses the EthClist stuff.
| >
| >
| >
| Agreed, I only found this when having a short look at, and was
pretty
| sure that gtkclist.c was simply not ok any more!
| As I don't use cygwin for this build variant, I just cannot say if
this
| step is true any longer.
Which I cannot tell anymore either as I used to build Ethereal with
GTK+ 1.x on cygwin (yielding the description from README.win32) but
now I only build with GTK+ 2.0. Additionally, the cygwin patches for
GTK+ 1.x are hard to find now.
The reason one needed to get rid of the private gtk_c_list stuff was
that it collided with the public version available in the GTK+ code.
Renaming the widget should solve the problem so we can just get rid of
that (previously required) removal.
Regards,
Olivier
