Ethereal-dev: RE: [Ethereal-dev] Glib noise with -pedantic

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Biot Olivier <Olivier.Biot@xxxxxxxxxxx>
Date: Mon, 2 Feb 2004 09:49:22 +0100
Hi all,

The fix seems to have made it into GLib 2.4.0:

Please do not reply to this email- if you want to comment on the bug, go to
the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=131899

Changed by otaylor [ad] redhat.com.

--- shadow/131899	Fri Jan 30 20:59:44 2004
+++ shadow/131899.tmp.1862	Sat Jan 31 09:38:45 2004
@@ -7,16 +7,21 @@
 Resolution: 
 Severity: normal
 Priority: Normal
 Component: general
 AssignedTo: gtkdev [ad] gtk.org                            
 ReportedBy: olivier.biot [ad] siemens.com               
-TargetMilestone: 2.4.1
+TargetMilestone: 2.4.0
 URL: 
 Summary: gmacros.h - G_STMT_START should have __extension__ on GCC
 
 When compiling a Glib application with -pedantic, code using the g_assert
 () macro and the like generates lots of noise (braces within expressions).
 
 I propose to get rid of this noise by adding __extension__ (or the GLIB 
 alias for it) to the G_STMT_START macro in gmacros.h when using a GCC 
 version supporting __extension__.
+
+------- Additional Comments From otaylor [ad] redhat.com  2004-01-31 09:38
-------
+I see no reason why this change can't go in for 2.4.0 -- we already
+use __extension__ in a similar case for _G_BOOLEAN_EXPR()
+

| -----Original Message-----
| From: Guy Harris
| 
| On Mon, Jan 19, 2004 at 11:37:57PM +0100, Olivier Biot wrote:
| > Mmh... I currently cannot compile GLib 1.x but I assume this also
| > applies to GLib 1.x as it (still) applies to GLib 2.0. The 
| only way to
| > know is by looking at the definition of g_assert() and
| > g_assert_not_reached(). I expect those macros are identical in both
| > GLib versions.
| 
| It appears to work with GLib 1.2[.x], although you change 
| glib.h rather
| than gmacros.h.

As we're doing debug work on Ethereal using GLib/GTK, maybe we can
contribute some more patches to them :)

Regards,

Olivier