On Fri, Jan 30, 2004 at 09:57:19PM +0100, Olivier Biot wrote:
> Now that we don't put carriage returns in the display filter anymore,
> the dialog for "Filter out this stream" doesn't show up anymore after
> 2 or 3 filtered-out streams (probably because the dialog becomes too
> wide, however I see no error or warning message).
By "the dialog" are you referring to the progress dialog when filtering?
I'll assume that's the case.
> Should we keep two
> versions of the filter string for this peculiar situation (one for the
> dialog, another for the display filter)?
The dialog (by which I assume you mean the progress dialog when
filtering) didn't work right with the newlines in the filter, either -
the titles for the items in the dialog box didn't line up with the
items.
Furthermore, the underlying problem exists for any long display filter,
regardless of how it's generated.
If we were to display the filter in the dialog box, we'd either have to:
1) cut it off if it's too long, perhaps putting in "...";
2) word-wrap it, which would require that we handle multi-line
displays of filter expressions - that might require us to use
a GtkTable rather than two parallel vboxes.
I'd vote for 1) - a sufficiently long filter expression probably isn't
going to be very meaningful in the progress dialog.
