Wireshark · Ethereal-dev: RE: [Ethereal-dev] Patch to packet SIP to make content type lower case, Patch to packet-isup to avoi

["Anders Broman (TN/EAB)" <anders.broman@xxxxxxxxxxxx>]

Hi,
Just to clearify the intent:

Currently the SDP dissector adds /SDP in the protocoll column e.g
a MEGACO message with SDP descriptions would show up as
MEGACO/SDP in the protocol column, this sort of make sense as SDP just decodes
a part of the MEGACO message "written in SDP" the same is true for SIP and BICC.
 I was thinking that if there was a SIP message with ISUP ( and SDP ) parts included in it
it would make sense to show it as SIP/ISUP/SDP as the "main" message still is SIP or perhaps only "SIP" ?

Currently the message will show "application/ISUP/SDP" ( as SIP is owerwritten )at least it should be changed
to "ISUP/SDP" or "ISUP(ITU)/SDP" in my opinion.

Comments wellcome.

Best regards
Anders

-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx]On Behalf Of Olivier Biot
Sent: den 19 januari 2004 00:24
To: Anders Broman
Cc: ethereal-dev@xxxxxxxxxxxx
Subject: Re: [Ethereal-dev] Patch to packet SIP to make content type
lower case, Patch to packet-isup to avoid owerwriting 'SIP' in Proto
column


The SIP patch has been checked in.

I don't think it makes sense to add more than one protocol in the
PROTOCOL column for a single packet, so I did not check in the ISUP
patch (yet). Any comments on this from the list?

Regards,

Olivier
----- Original Message ----- 
From: Anders Broman
To: ethereal-dev@xxxxxxxxxxxx
Sent: Sunday, January 18, 2004 11:29 PM
Subject: [Ethereal-dev] Patch to packet SIP to make content type lower
case,Patch to packet-isup to avoid owerwriting 'SIP' in Proto column


Hi,
Included patch to packet-sip makes content-type to lower case string
and saves pinfo->private_data before calling media type dissector.
The ISUP patch changes the entry in protocol column to ISUP(ITU) and
uses col_append_string ( like the SDP dissector does ).

BTW should packet-multipart.c do set_col_fence in the proto column as
well as in the info column ?

Best regards
Anders




_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev


_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev