Ethereal-dev: Re: [Ethereal-dev] radius patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Joost Yervante Damad <Joost.Damad@xxxxxxxxxxx>
Date: Mon, 12 Jan 2004 08:29:22 +0100
On Fri, Jan 09, 2004 at 03:46:05PM -0800, Guy Harris wrote:
> 
> On Jan 9, 2004, at 6:26 AM, Joost Yervante Damad wrote:
> 
> >the following diff adds 3 new vendors, 3 non-encapsulated Merit vendor
> >specifics, displaying of the authenticator in the protocol tree and
> >possibility to display-filter on selected attributes:
> 
> The RADIUS dissector has been somewhat reorganized since 0.10.0, to 
> clean it up.  The "possibility to display-filter on selected 
> attributes" part of the patch didn't apply, due to that change.
> 
> Note that, in the future, we might want to load the RADIUS dictionary 
> information from a file, rather than having a lot of hardcoded stuff in 
> the dissector.  That might somewhat complicate the code to make some 
> attributes filterable.

Hi,

I'm not really convinced that my way of filtering on attributes is the
way to go. Maybe you can just apply the part with the vendors, the
vendor specifics, and the displaying of the authenticator?
Having the authenticator visible in the tree is invaluable for detecting
malformed packets with one eye gaze.

Thanks, Joost Damad