Ethereal-dev: [Ethereal-dev] The save un-filtered check box and the tool tip in Save As... and

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Richard Sharpe <rsharpe@xxxxxxxxxxxxxxxxx>
Date: Thu, 1 Jan 2004 16:33:21 -0800 (PST)
Hi,

I feel that I must point out that the current tooltip on the Save As... 
dialog box, which says the following:

	Save the packets from the above chosen range, but only the 
	displayed ones

Is not actually correct, because if you look at the following routines:

  gboolean packet_range_process_all(packet_range_t *range) {
    return range->process_all && !range->process_filtered;
  }

it explicitely looks at range->process_filtered, as does 
packet_range_process.

So, the check box applies to almost all the items above in the dialog box, 
which means that the message should be more general.

Regards
-----
Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org, 
sharpe[at]ethereal.com, http://www.richardsharpe.com