Michael,
I already pasted the declarations of packet-x11.h into packet-x11.c, added
some missing { 0, NULL } final entries in value_string[]s, and used your
defined values in the 2 other value_string[] constructs.
Do you have an updated x11-fields file? This one generates the
x11-declarations.h and x11-register-info.h files by means of the
process-x11-fields.pl script.
Regards,
Olivier
| -----Original Message-----
| From: Michael Shuldman
|
| Biot Olivier wrote,
| > | From: Michael Shuldman
| > |
| > | Biot Olivier wrote,
| > | > Could you tell me which Ethereal version you patched the
| > | X11 dissector?
| > |
| > | This was for the last (?) version, ethereal-0.10.0a.
| >
| > Strange, as the RCS identifier and the includes of the
| packet-x11.c you sent
| > are different:
| >
| > /*
| > * $Id: packet-x11.c,v 1.11 2003/12/29 13:30:57 michaels
| Exp michaels $
| > */
| > #include "packet-x11.h"
| > #include "keysymdef.h"
| >
| > [I suppose you're working on a private CVS repository based
| on current
| > Ethereal, and that this is version 1.11 within your
| *private* repository.]
|
| Yeah, I used rcs myself while working on it.
|
| > If the X11 protocol needs to export functionality to other parts of
| > Ethereal, then packet-x11.h makes sense; if it only
| contains declarations
| > static to X11 then it doesn't.
|
| It only contains stuff relevant to X11, I take it you mean
| you don't want another extra file and want to put it into a
| previously existing file?
|
| > I suppose the file keysymdef.h is a modified version of the
| > packet-x11-keysym.h file.
|
| Mmm, actually no. I suppose they could well be merged
| together though,
| since the contents is related.
|
| > Another quick look at the differences between existing and
| new X11 dissector
| > shows that some macros don't expand to expressions within
| curly braces
| > anymore. I suppose this was intentional.
|
| Yes, I wanted the value too, not just set the variable.
|
|
| > I at least need your packet-x11.h file (and preferably also
| your keysymdef.h
| > file) in order to compile Ethereal.
|
| Weren't they included in my mail? According to my mailfolder, I
| sent the following files:
|
| 2 [text/plain, 7bit, 34K] packet-x11-keysym.h
| 3 [text/plain, 7bit, 120K] packet-x11.c
| 4 [text/plain, 7bit, 8.0K] packet-x11.h
| 5 [text/plain, 7bit, 16K] x11-declarations.h
| 6 [text/plain, 7bit, 48K] x11-register-info.h
| 7 [text/plain, 7bit, 84K] keysymdef.h
| 8 [text/plain, 7bit, 3.3K] docdiff
|
| Let me know if something went wrong and I can re-send them,
| or if there's anything else I can do to help.
|
|
| --
| _ //
| \X/ -- Michael Shuldman <michaels@xxxxxxx>
|
