Hi Hannes,
> | As "Source-ID:" and "Start LSP-ID:" are aligned, I see no reason not to
> | align "End LSP-ID:" with its peers.
>
> can you give a reason _why_ it should get aligned ?
Aligned output of protocol filed values is more agreeable to users.
Per my experience on IS-IS development, I found IS-IS PDU Header and IS-IS Hello PDU Header very agreeable to me.
When I was quite familiar with PDU structure/encoding, I can easily get the field values when they are aligned without looking at field definitions.
Take IP Header for example, I think it will be more agreeable if the field values are aligned, especially to those who use it intensively.
Don't you think so?
I am not sure about the problem you concern.
Would you show me more details like filename, line number and related output?
You are welcome to send emails to my mailbox: feiyunw at yahoo dot com.
Merry Christmas and Happy New Year!
Best regards,
Feiyun Wang
----- Original Message -----
From: "Hannes Gredler" <hannes@xxxxxxxxxxx>
To: "Feiyun Wang" <fywang@xxxxxxxxxxxxxxxxxx>
Cc: <ethereal-dev@xxxxxxxxxxxx>
Sent: Wednesday, December 24, 2003 6:31 AM
Subject: Re: [Ethereal-dev] ISIS PDU display enhancement request
> On Tue, Dec 23, 2003 at 11:05:09AM +0800, Feiyun Wang wrote:
> | Hi all,
> |
> |
> |
> | I am requesting a trivial display enhancement for ISIS protocol CSNP PDU (on
> | Ethereal 0.10.0).
> |
> |
> |
> | In displaying ISIS L1/L2 CSNP, I suggest to change the output like this:
> |
> | Source-ID: 0001.0001.0008.00
> | Start LSP-ID: 0000.0000.0000.00-00
> | - End LSP-ID: ffff.ffff.ffff.ff-ff
> | + End LSP-ID: ffff.ffff.ffff.ff-ff
> | As "Source-ID:" and "Start LSP-ID:" are aligned, I see no reason not to
> | align "End LSP-ID:" with its peers.
>
> can you give a reason _why_ it should get aligned ?
>
> /hannes
>
> P.S. i am working on name resolution for IS-IS which will display
> variable length names - ultimately this screws any script that
> relies on fixed offsets - so i wondered if there are other
> reasons than (just guessing) scripts simple;
>
