Ethereal-dev: Re: [Ethereal-dev] SoulSeek Dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Sat, 20 Dec 2003 18:30:36 +0100
On Wed, Dec 10, 2003 at 06:17:04PM +0100, Kendy Kutzner wrote:
> On 2003-12-10T17:39:20+0100, Joerg Mayer wrote:
> > I noted two c++ style comments in the code and it looks like they were
> > sort of work/fix-in-progress.
> 
> They were just tests, patch to remove them is attached.

Two more things (the first one can be found in doc/README.developer
section 1.1.1).

Some older compilers do not support declarations after statements,
and this is done in several places in the code. Please fix this.

Your code uses zlib. There are platforms that don't have zlib, so
a) the include  should be wrapped into #if HAVE_LIBZ and
b) the code that uses it should be wrapped likewise and just return
   an error code in case zlib is not present on the build system.

  Ciao
     Jörg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.