Ethereal-dev: Re: [Ethereal-dev] Some curious code in gtk/proto_draw.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Richard Sharpe <rsharpe@xxxxxxxxxxxxxxxxx>
Date: Thu, 27 Nov 2003 15:00:51 -0800 (PST)
On Thu, 27 Nov 2003, Guy Harris wrote:

> On Thu, Nov 27, 2003 at 12:19:03AM -0800, Richard Sharpe wrote:
> > I just noticed the following in proto_draw.c:packet_hex_print:
> > 
> >   OBJECT_SET_DATA(bv, E_BYTE_VIEW_START_KEY, GINT_TO_POINTER(bend));
> >   OBJECT_SET_DATA(bv, E_BYTE_VIEW_END_KEY, GINT_TO_POINTER(bstart));
> > 
> > Why do we store bend under E_BYTE_VIEW_START_KEY and bstart under 
> > E_BYTE_VIEW_END_KEY?
> 
> Good question.
> 
> Why does Ethereal appear to correctly redisplay the highlighted section
> if you change the highlighting mode, given that the start and end values
> are reversed?

I think that the code that retrieves the info knows about this reversal. 
However, it looks wrong.

Regards
-----
Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org, 
sharpe[at]ethereal.com, http://www.richardsharpe.com