Ethereal-dev: Re: [Ethereal-dev] RTP Analysis: Need help withredissect_packetsimplementation d

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: didier <dgautheron@xxxxxxxx>
Date: Fri, 21 Nov 2003 14:00:10 +0000
Ronnie Sahlberg wrote:

OK.
I understand.

Well I dont really know whether we need the proto tree or not for taps in
all situations.

The taps only really need two things:
1,  the dissector must be called so it can call tap_queue_packet() so the
tap can pick it up in the _packet() function.
2,  IF the tap use a filter, then we must dissect all packets so we can
evaluate the filter string.


Please have a go and see if you can come up with an improvement, thats what
open source is for.
I ALWAYS use colorfilters  or rather one colorfilter : "tcp.analysis.flags"
so I wont benefit from any
speedups anyway.
Yes you will, if it only parses tree in tcp dissector and not in frame/ip and tcp subdissectors, assuming that tcp dissector doesn't need stuff from frame/ip. 
in filter compiler we know fields used:
for each field find prtocol owner
    flag protocol

and  in each dissector
if not flaged
   working_tree = null

Didier