Ethereal-dev: Re: [Ethereal-dev] Packet-wbxml.c - various updates

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Thu, 20 Nov 2003 14:27:18 -0800

On Nov 20, 2003, at 10:43 AM, Biot Olivier wrote:


Attached patch performs the following:
* Fix an incorrectly #ifdef'ed return introduced by the previous patch
* Remove the parsed_length parameter from the function signature of the tag 
and attribute dissectors
* Produce consistent and extensive debug logging (enabled by defining
DEBUG_wbxml)
* Get rid of the dozens of "#ifdef DEBUG ... #endif" constructs for debug 
logging

Please review
You might want to use "tvb_ensure_bytes_exist()" to do the "Check that there is still room in packet" stuff - it'll throw the appropriate exception. (It won't do the DebugLog stuff, however.) 


 and check in.


Done.