Ethereal-dev: Re: [Ethereal-dev] Patch to packet-wbxml.c - short frames and extra debug loggin

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 19 Nov 2003 14:14:51 -0800

On Nov 19, 2003, at 1:57 PM, Biot Olivier wrote:


Attached patch fixes the WBXML dissector in cases where dissection is
interrupted because of a short frame or packets not being reassembled.
Perhaps "parse_wbxml_attribute_list_defined()" should return the length as its return value, rather than returning it through a pointer, and should return -1 in the RESERVED_2 token case.
That would, I think, mean that it'd either return -1, or an offset that is, at most, one byte past the end of the data in the tvbuff (as the byte just before that would have been fetched from the tvbuff, and if *that* byte wasn't there, that'd throw an exception and abort the dissection). 

In that case, I don't think you'd need to add that check.