Ethereal-dev: Re: [Ethereal-dev] Ethereal performance, after Guy's changes ...

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 19 Nov 2003 01:28:12 -0800
On Wed, Nov 19, 2003 at 09:24:21AM +0100, Lars Ruoff wrote:
> Note that registering the tap on demand means that the whole file does have
> to get redissected (long on large files) before being able to show the RTP
> streams list. (Registering on startup means the RTP streams list is
> available right after file import)
> Perhaps there could be a user preference option indicating wether the tap
> should be registered on startup?

Perhaps there should be a way to make that tap run without building a
protocol tree.

The tap itself doesn't need the protocol tree.

It uses a filter, which would require a protocol tree, but

	1) the "rtp" part of the filter is unnecessary, as it should
	   only be called for RTP packets, given that it's handed RTP
	   information;

	2) the "ip" part could be tested by the tap looking at the
	   source and destination addresses pointed to by "pinfo"
	   (although it should perhaps handle IPv4 *and* IPv6);

	3) the "!icmp" part could be handled by checking
	   "pinfo->in_error_pkt" (although the RTP dissector should
	   probably do that itself, not calling "tap_queue_packet()" for
	   error packets;

so the filter shouldn't need the protocol tree, either.