Ethereal-dev: RE: [Ethereal-dev] capture.c: seperate the mix of GTK and GUI ind ependant thing
Great!
It would also be useful in tethereal compilations where GTK includes are
used although they are not needed.
Regards,
Olivier
| -----Original Message-----
| From: Ulf Lamping
|
| Hi List!
|
| The stuff in the file "capture.c" is currently a mix of the
| "capturing
| engine" and the GTK things involved with it.
|
| Currently capture.c consists of three "main topics":
| -generic capturing things (wiretap, pcap, ...)
| -capture info GTK dialog (the one displayed when the capture
| is in progress)
| -GTK specifics (some of the pipe handling, ...)
|
| IMHO it would be nice to seperate the generic capturing
| things (leave it
| in the "capture.c" file) and put the GTK specific things into
| the gtk dir.
|
| What I've already done (in my own source tree) is seperating
| the dialog
| things, and put it in a new file "gtk/capture_info_dlg.c"
|
|
| Questions about this task:
|
| Is it really a good idea to do this? Or are there reasons why the
| current implementation is the better way?
| Is there a better name/place than "gtk/capture_info_dlg.c"?
|
| Regards, ULFL
