Ethereal-dev: Re: [Ethereal-dev] improved NTP decoding

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Matthias Drochner <M.Drochner@xxxxxxxxxxxxx>
Date: Wed, 12 Nov 2003 22:05:14 +0100
guy@xxxxxxxxxxxx said:
> Checked in, with some changes: 

Thanks...

> 	I moved the "dissect_ntp_std()" code one tab stop to the left;

This was intentional, to keep the diff size small.

> 	I changed "dissect_ntp_ext()" *not* to require that the offset be 48 
> bytes (dissecting multiple extensions should work fine - at least from 
> the ntpd code I've seen

It is fine from the NTP point of view -- I just wasn't sure it is legal
to use one hf_* node multiple times within one packet. The documentation
isn't clear about this. In real live as far as I've seen, multiple
extensions didn't happen. So I couldn't test and preferred to be conservative.

best regards
Matthias