Ethereal-dev: Re: [Ethereal-dev] Portability patches

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Albert Chin <ethereal-dev@xxxxxxxxxxxxxxxxxx>
Date: Sun, 9 Nov 2003 18:20:36 -0600
On Sun, Nov 09, 2003 at 02:19:40PM -0800, Guy Harris wrote:
> On Sun, Nov 09, 2003 at 04:07:35AM -0600, Albert Chin wrote:
> > 1. HP C compiler complains about typedef before enum declared
> >    (HP-UX 10.20).
> 
> Checked in.  (Is that legal ANSI C, or is that just an HP C compiler
> deficiency?  My ANSI C standard is at work....)

Dunno. My copy is at work too :)

> > 3. P_SID in <sys/procset.h> on HP-UX 10.20 and Tru64 UNIX.
> 
> I checked in a change a few days ago to get rid of includes of
> <gmodule.h>, <sys/types.h>, and <netinet/in.h>; I don't think they're
> needed, and they might keep <sys/procset.h> from being included.
>
> See whether getting rid of those #includes, and reverting back to P_SID,
> works.

I copied the latest packet-ansi_a.c from CVS and still get the error.

> > 4. HP C compiler on HP-UX 10.20 complains about the initializer for
> >    ett ("Array size must be a constant expression.").
> 
> At least as I read that code, it *is* a constant expression; am I
> missing something, or is this a deficiency of that C compiler?

Looks like a deficiency of the compiler. This works:
  static gint *ett[sizeof(ansi_dtap_strings)/sizeof(value_string)]
But this does not:
  static gint *ett[sizeof(ansi_dtap_strings)/sizeof(value_string) < 0 ? 0 : 1]

-- 
albert chin (china@xxxxxxxxxxxxxxxxxx)