Ethereal-dev: Re: [Ethereal-dev] patch for packet-smb.c (Locking_AndX)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Ronnie Sahlberg" <ronnie_sahlberg@xxxxxxxxxxxxxx>
Date: Sun, 9 Nov 2003 08:08:01 +1100
I am not sure this fix is correct.

http://www.ethereal.com/cgi-bin/viewcvs.cgi/ethereal/packet-smb.c.diff?r1=1.365&r2=1.366
The reason it was changed  FROM what you suggest TO what it is corrently
was based on what real Microsoft Clients/Servers report in the call.


----- Original Message ----- 
From: "Luis Claudio R. Goncalves"
Sent: Saturday, November 08, 2003 7:02 AM
Subject: [Ethereal-dev] patch for packet-smb.c (Locking_AndX)


> Hi!
>
> I've been playing around with locks in samba and I've seen that the offset
> and length reported by ethereal for large file locks are not the same I've
> requested and thus not the same reported by samba logs.
>
> The locking offset and length are 64bit integers sent as OffsetHigh
(32bit)
> and OffsetLow (32bit). The glitch seems to be only the mix between high
and
> low 32bit words.
>
> The patch attached just does a little change in
> dissect_locking_andx_request(), file packet-smb.c
>
> I tried it with ethereal-0.9.10 and I've seen that this code still be the
> same in 0.9.16.
>
> Regards,
> Luis
>
> PS: I'm not subscribed to this mailing list... :)
> --