Ethereal-dev: Re: [Ethereal-dev] [Patch] asn1 plugin

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 3 Nov 2003 13:27:16 -0800

On Nov 3, 2003, at 5:35 AM, Gisle Vanem wrote:
Perhaps "get_tempfile_path()" should default to "c:\temp" if it exists, 
and "c:\" if it doesn't.


Would be okay assuming the user have a C: drive. Someone
might want to run Ethereal on diskless or other excotic PC
mapped to a network share.
Your patch, it appears, defaults to C:\ if there was no setting for "TEMP"; are you saying that wasn't the right thing to do?
Also, note that there's a routine "create_tempfile()" in "util.c" - but, 
on UNIX, it defaults to "/var/tmp" rather than "/tmp".  Should it use
"get_tempfile_path()"? And should "get_tempfile_path()" default to
"/tmp" or "/var/tmp" on UNIX?


You mean if a $TMP doesn't exists, or always?
"Defaults", in my previous message, means "if the environment variable for the temporary file directory isn't set". 


Or we could use 'get_persconffile_dir()'. It would be personal enough
and it's only one file there on my PC.
That's the wrong place to put temporary files. If some particular OS insists on making the temporary file directory per-user, then I guess we should put things there, but they don't belong in the directory for personal configuration files.