Ethereal-dev: Re: [Ethereal-dev] Patch: packet-wsp.c major rewrite

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 3 Nov 2003 02:17:53 -0800
On Fri, Oct 31, 2003 at 08:36:05PM +0100, Biot Olivier wrote:
> As promised a looooong time ago, here's the 1st patch to the WSP dissector.

Checked in, along with your second patch, and along with a change to
remove the final semicolon from the "wkh_0_Declarations" macro - calls
to that macro are always followed by a semicolon:

	wkh_0_Declarations;

and with the semicolon after

	guint8 *val_str = NULL

that caused the declaration to be

	guint8 *val_str = NULL;;

A ";" is an executable statement, so if there were any declarations
*after*

	wkh_0_Declarations;

they'd get an error, which was the cause of the compile problems I
mentioned in my mail.