Wireshark · Ethereal-dev: Re: [Ethereal-dev] New release rush - small patch for packet-dcerpc.c, big patch for packet-dcerpc-o

[Guy Harris <guy@xxxxxxxxxxxx>]

On Oct 27, 2003, at 1:59 PM, Guy Harris wrote:

> So is the intent that everything that needs stuff from 
> "packet-dcerpc-dcom.c" #include it?
>
> If so, then:
>
> 	1) you get multiple versions of the same function if more than one 
> source file includes it - is that intended?  (I suppose you get some 
> locality of reference for code that way....)
>
> 	2) perhaps it should be ".inc" rather than ".c", as it's not a 
> top-level source file.

and

	3) unless every module that includes "packet-dcerpc-dcom.c" uses every 
single routine and variable in it, you get compiler warnings.